Updates to Filters::FilterForm to make it work with Query#23457
Merged
Conversation
Contributor
Author
|
Eventhough it sounds related, the failing spec is on |
dfriquet
reviewed
Jun 1, 2026
Contributor
dfriquet
left a comment
dfriquet
left a comment
There was a problem hiding this comment.
One question to answer before I can approve 👍
dfriquet
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Another Follow Up for https://community.openproject.org/wp/74380
What are you trying to accomplish?
Screenshots
What approach did you choose and why?
Merge checklist